Fix bug in matrix add_mul (#55)

jump-dev · Nov 2, 2020 · 464faa0 · 464faa0
1 parent 7057356
commit 464faa0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/linear_algebra.jl b/src/linear_algebra.jl
@@ -180,7 +180,7 @@ function _add_mul_array(C::Matrix, A::AbstractMatrix, B::AbstractMatrix)
 
     @inbounds begin
         for i = 1:size(A, 1), j = 1:size(B, 2)
-            Ctmp = zero!(C[i, j])
+            Ctmp = C[i, j]
             for k = 1:size(A, 2)
                 Ctmp = buffered_operate!(mul_buffer, add_mul, Ctmp, A[i, k], B[k, j])
             end

diff --git a/test/matmul.jl b/test/matmul.jl
@@ -147,3 +147,11 @@ end
         alloc_test(() -> MA.mutable_operate!(MA.add_mul, C, A, B), 48)
     end
 end
+
+@testset "matrix multiplication" begin
+    X = ones(BigInt, 1, 1)
+    M = ones(1, 1);
+    C = X * M
+    D = MA.operate!(MA.add_mul, C, X, M)
+    @test D == X * M + X * M
+end