Fix Vector*Transpose{Vector} (#257)

jump-dev · Feb 14, 2024 · 3a1ca9b · 3a1ca9b
1 parent 48569d2
commit 3a1ca9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/implementations/LinearAlgebra.jl b/src/implementations/LinearAlgebra.jl
@@ -216,6 +216,13 @@ function promote_array_mul(
     return Matrix{promote_sum_mul(S, T)}
 end
 
+function promote_array_mul(
+    ::Type{<:AbstractVector{S}},
+    ::Type{<:LinearAlgebra.Transpose{T,<:AbstractVector{T}}},
+) where {S,T}
+    return Matrix{promote_sum_mul(S, T)}
+end
+
 function promote_array_mul(
     ::Type{<:AbstractMatrix{S}},
     ::Type{<:AbstractVector{T}},

diff --git a/test/matmul.jl b/test/matmul.jl
@@ -396,3 +396,10 @@ end
     @test MA.operate(*, x22, y) == x22 * y
     @test MA.operate(*, y, x22) == y * x22
 end
+
+@testset "Vector*Transpose{Vector}_issue_256" begin
+    x = BigInt[1 2; 3 4]
+    A = [1 2; 3 4]
+    y = MA.@rewrite sum(A[i, :] * LinearAlgebra.transpose(x[i, :]) for i in 1:2)
+    @test y == BigInt[10 14; 14 20]
+end