Skip to content

Commit

Permalink
copy for BigInt, BigFloat and Rational
Browse files Browse the repository at this point in the history
Fixes #163
  • Loading branch information
nsajko committed Nov 26, 2023
1 parent 6e6a854 commit 38a897e
Show file tree
Hide file tree
Showing 6 changed files with 75 additions and 12 deletions.
30 changes: 19 additions & 11 deletions src/implementations/BigFloat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,24 @@ end

const _MPFRRoundingMode = Base.MPFR.MPFRRoundingMode

# copy

promote_operation(::typeof(copy), ::Type{BigFloat}) = BigFloat

function operate_to!(out::BigFloat, ::typeof(copy), in::BigFloat)
ccall(
(:mpfr_set, :libmpfr),
Int32,
(Ref{BigFloat}, Ref{BigFloat}, _MPFRRoundingMode),
out,
in,
Base.MPFR.ROUNDING_MODE[],
)
return out
end

operate!(::typeof(copy), x::BigFloat) = x

# zero

promote_operation(::typeof(zero), ::Type{BigFloat}) = BigFloat
Expand Down Expand Up @@ -371,17 +389,7 @@ function buffered_operate_to!(
x::AbstractVector{F},
y::AbstractVector{F},
) where {F<:BigFloat}
local set! = function (out::F, in::F)
ccall(
(:mpfr_set, :libmpfr),
Int32,
(Ref{BigFloat}, Ref{BigFloat}, Base.MPFR.MPFRRoundingMode),
out,
in,
Base.MPFR.ROUNDING_MODE[],
)
return nothing
end
set! = (o, i) -> operate_to!(o, copy, i)

local swap! = function (x::BigFloat, y::BigFloat)
ccall((:mpfr_swap, :libmpfr), Cvoid, (Ref{BigFloat}, Ref{BigFloat}), x, y)
Expand Down
11 changes: 11 additions & 0 deletions src/implementations/BigInt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@ mutability(::Type{BigInt}) = IsMutable()
# https://github.com/JuliaLang/julia/blob/7d41d1eb610cad490cbaece8887f9bbd2a775021/base/gmp.jl#L772
mutable_copy(x::BigInt) = Base.GMP.MPZ.set(x)

# copy

promote_operation(::typeof(copy), ::Type{BigInt}) = BigInt

function operate_to!(out::BigInt, ::typeof(copy), in::BigInt)
Base.GMP.MPZ.set!(out, in)
return out
end

operate!(::typeof(copy), x::BigInt) = x

# zero

promote_operation(::typeof(zero), ::Type{BigInt}) = BigInt
Expand Down
12 changes: 12 additions & 0 deletions src/implementations/Rational.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@ mutability(::Type{Rational{T}}) where {T} = mutability(T)

mutable_copy(x::Rational) = Rational(mutable_copy(x.num), mutable_copy(x.den))

# copy

promote_operation(::typeof(copy), ::Type{Q}) where {Q<:Rational} = Q

function operate_to!(out::Q, ::typeof(copy), in::Q) where {Q<:Rational}
operate_to!(out.num, copy, in.num)
operate_to!(out.den, copy, in.den)
return out
end

operate!(::typeof(copy), x::Rational) = x

# zero

promote_operation(::typeof(zero), ::Type{Rational{T}}) where {T} = Rational{T}
Expand Down
2 changes: 1 addition & 1 deletion src/interface.jl
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ operate(::typeof(convert), ::Type{T}, x) where {T} = convert(T, x)

operate(::typeof(convert), ::Type{T}, x::T) where {T} = copy_if_mutable(x)

function operate(::Union{typeof(+),typeof(*),typeof(gcd),typeof(lcm)}, x)
function operate(::Union{typeof(copy),typeof(+),typeof(*),typeof(gcd),typeof(lcm)}, x)
return copy_if_mutable(x)
end

Expand Down
30 changes: 30 additions & 0 deletions test/copy.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Copyright (c) 2023 MutableArithmetics.jl contributors
#
# This Source Code Form is subject to the terms of the Mozilla Public License,
# v.2.0. If a copy of the MPL was not distributed with this file, You can obtain
# one at http://mozilla.org/MPL/2.0/.

@testset "copy: $T" for T (Float64, BigFloat, Int, BigInt, Rational{Int}, Rational{BigInt})
@test MA.operate!!(copy, T(2)) == 2
@test MA.operate_to!!(T(3), copy, T(2)) == 2
if MA.mutability(T, copy, T) == MA.IsMutable()
@testset "mutable" begin
@testset "correctness" begin
x = T(2)
y = T(3)
@test MA.operate!(copy, x) === x == 2
@test MA.operate_to!(y, copy, x) === y == 2
end
@testset "alloc" begin
f = let x = T(2)
() -> MA.operate!(copy, x)
end
g = let x = T(2), y = T(3)
() -> MA.operate_to!(y, copy, x)
end
alloc_test(f, 0)
alloc_test(g, 0)
end
end
end
end
2 changes: 2 additions & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ include("interface.jl")

include("range.jl")

include("copy.jl")

@testset "Int" begin
include("int.jl")
end
Expand Down

0 comments on commit 38a897e

Please sign in to comment.