[Bridges.Variable] add bridges in alphabetical order and change weight #2599
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Dec 30, 2024
| @@ -56,6 +56,8 @@ end | |||
| const RSOCtoPSD{T,OT<:MOI.ModelLike} = | |||
| SingleBridgeOptimizer{RSOCtoPSDBridge{T},OT} | |||
|
|
|||
| MOI.Bridges.bridging_cost(::Type{<:RSOCtoPSDBridge}) = 1.5 | |||
There was a problem hiding this comment.
So there's an argument to be made here. Would it be better to globally penalise PSD sets more than RSOC sets? We're starting to muck with bridge costs, and it becomes a bit subjective.
There was a problem hiding this comment.
It's debatable, this one is clearly destructing structure so it make sense to give it a high cost. But this would be inferrable form a higher cost given to PSD variables. You can even give a higher cost than 1.5 like 5 or 10, it should really only be used when there is no other choice ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2596
The behaviour should, where possible, not depend on this somewhat arbitrary order of bridges in this function. That is too brittle and the behaviour is undocumented.