Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in getindex(::AbstractModel, ::Symbol) #3868

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Nov 5, 2024

We don't use nothing to signify duplicates since we now call _error_if_cannot_register.

And this branch can give a very misleading error if someone actually wants to put nothing in there.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (139bead) to head (28a8f1f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
+ Coverage   97.55%   97.57%   +0.01%     
==========================================
  Files          44       44              
  Lines        6059     6057       -2     
==========================================
- Hits         5911     5910       -1     
+ Misses        148      147       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit b68df42 into master Nov 5, 2024
11 checks passed
@odow odow deleted the od/obj-dict branch November 5, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant