Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add section on debugging performance issues #3850

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented Oct 10, 2024

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (5975249) to head (9950916).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3850   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          44       44           
  Lines        6017     6027   +10     
=======================================
+ Hits         5869     5879   +10     
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat
Copy link
Member

blegat commented Oct 10, 2024

I also find it helpful to just call attach_optimizer but not optimize! to see which part is copying the model

@odow odow merged commit 4876764 into master Oct 10, 2024
12 of 13 checks passed
@odow odow deleted the od/debug-performance branch October 10, 2024 23:41
@odow
Copy link
Member Author

odow commented Oct 10, 2024

I chose not to mention attach_optimizer. It's a bit too complicated for a common user question in a getting started tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants