Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add missing warning from #3836 #3842

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Oct 8, 2024

Looks like the warning got dropped before merging

Looks like the warning got dropped before merging
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (e78a3a4) to head (d829d0a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
- Coverage   97.90%   97.50%   -0.41%     
==========================================
  Files          44       44              
  Lines        6028     6017      -11     
==========================================
- Hits         5902     5867      -35     
- Misses        126      150      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Oct 8, 2024

I decided not to add this in that PR because we never mention AutoEnzyme. I'm reticent to specifically call out DI for failing to work with one example with Enzyme, and "May be slower" is not important (performance is not the most important consideration) for JuMP users.

We also already have a native Enzyme code example in the tutorial above, which seems preferable to me.

How about something more generic:

# !!! warning
#     The JuMP developers cannot help you debug error messages related to
#     DifferentiationInterface. If the operator works, it works. If not, we
#     suggest you try a different automatic differentiation library. See
#     [juliadiff.org](https://juliadiff.org/) for details.

@odow
Copy link
Member

odow commented Oct 8, 2024

Doc build failed because of the switch in the last few hours from Julia 1.10 to Julia 1.11. It's fixed (by pinning 1.10) on master.

@wsmoses
Copy link
Contributor Author

wsmoses commented Oct 8, 2024

sure/done

@odow odow merged commit 19ad9b3 into jump-dev:master Oct 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants