Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add Rolling horizon tutorial #3815

Merged
merged 11 commits into from
Aug 31, 2024
Merged

[docs] add Rolling horizon tutorial #3815

merged 11 commits into from
Aug 31, 2024

Conversation

odow
Copy link
Member

@odow odow commented Aug 29, 2024

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (d2de3ab) to head (3772b30).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3815   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          44       44           
  Lines        6022     6022           
=======================================
  Hits         5896     5896           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow force-pushed the od/rolling-horizon branch from e7435be to 1edb3c6 Compare August 30, 2024 00:27
@odow
Copy link
Member Author

odow commented Aug 30, 2024

Okay @datejada, I've now made quite a few changes to your code--I hope you don't mind/agree with them.

I haven't really edited the first descriptive part. I'll wait for CI to see how the math renders, etc.

Still TODO:

  • Tidy the math part
  • I think we should show how this works with pure HiGHS. But using POI reduces the number of variables in the model. This does't work with HiGHS because it has A * i
  • Get rid of objective_function_per_window? I don't know what it adds.

@odow odow force-pushed the od/rolling-horizon branch from 2621956 to feec2c8 Compare August 30, 2024 01:50
@odow
Copy link
Member Author

odow commented Aug 30, 2024

So here's a nice plot:
image

@datejada
Copy link
Contributor

Hi @odow, Thank you so much; I like your improvements and changes 😄

You can delete the objective_function_per_window parameter. I had it to quickly check that my implementation was working, but you can remove it for a final version.

@odow odow merged commit 4783914 into master Aug 31, 2024
11 checks passed
@odow odow deleted the od/rolling-horizon branch August 31, 2024 21:10
@odow
Copy link
Member Author

odow commented Aug 31, 2024

Thanks @datejada!

@datejada
Copy link
Contributor

datejada commented Sep 1, 2024

@odow, thank you! The final version is awesome. I’m happy to have contributed the initial version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[docs] add datejada/rolling-horizon-example tutorial
2 participants