Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Convex.jl to solver list #3782

Closed
wants to merge 1 commit into from
Closed

Add Convex.jl to solver list #3782

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 14, 2024

The MOI wrapper was added in Convex.jl v0.16

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (7ca3799) to head (04da3e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3782   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          44       44           
  Lines        5907     5907           
=======================================
  Hits         5812     5812           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlubin
Copy link
Member

mlubin commented Jul 14, 2024

This needs more caveats, like those mentioned at https://github.com/jump-dev/Convex.jl?tab=readme-ov-file#using-with-jump.

@mlubin
Copy link
Member

mlubin commented Jul 14, 2024

I'm also having trouble thinking of which important use cases of DCP are covered without vector input functions like norm. Is it really worth advertising?

@odow
Copy link
Member

odow commented Jul 14, 2024

Agree. I'm still treating this as somewhat experimental.

@blegat
Copy link
Member Author

blegat commented Jul 15, 2024

I agree there is maybe not point advertising this yet, let's close this

@blegat blegat closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants