Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for unsupported kwargs in variable macro #3751

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

odow
Copy link
Member

@odow odow commented May 20, 2024

Closes #3750

@oxinabox is this enough?

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (a62eae7) to head (06561a1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3751   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          44       44           
  Lines        5867     5867           
=======================================
  Hits         5772     5772           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow mentioned this pull request May 21, 2024
Copy link

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will fill the need.

@odow odow merged commit ba2ded5 into master May 21, 2024
10 of 11 checks passed
@odow odow deleted the od/kwarg branch May 21, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fuzzy search on unrecognized keyword arguments to give suggestions
3 participants