Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vector-valued constraints in normalized_coefficient #3743

Merged
merged 5 commits into from
May 9, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 3, 2024

Closes #3742

One naming question:

We actually have set_normalized_coefficiets for this case:
https://jump.dev/JuMP.jl/stable/api/JuMP/#set_normalized_coefficients

So we should probably either call this normalized_coefficients, or rename set_normalized_coefficients to set_normalized_coefficient (but leave the current method for backwards compatibility).

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (18c01c4) to head (c3b4c3c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3743   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files          44       44           
  Lines        5857     5866    +9     
=======================================
+ Hits         5762     5771    +9     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/variables.jl Outdated Show resolved Hide resolved
@odow odow merged commit c65e0c9 into master May 9, 2024
11 checks passed
@odow odow deleted the od/normalized_coefficiennt branch May 9, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support normalized_coefficient for vector-valued constraints
3 participants