-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _CONSTRAINT_LIMIT_FOR_PRINTING to control printing of many constraints #3686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3686 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 43 43
Lines 5696 5711 +15
=======================================
+ Hits 5601 5616 +15
Misses 95 95 ☔ View full report in Codecov by Sentry. |
An alternative might be to print at most N constraints of each function-set type. That would give a more representative print of the model. |
I like MOI's |
Developer call agrees that we could do something different in the longer term, but that this is sufficient for now. We can merge and then wait to see if anyone complains. |
It would be nice if these kind of knobs be mentioned in the docs, |
We have purposefully chosen not to mention these in the docs. They are currently part of the internal API. Is there an issue with the current defaults? Why do you want to change them? |
(I agree that the current default is better than nothing, as discussed.) |
There are probably better tools for viewing a subset of constraints. For example, you could loop through |
Closes #3651
We need to decide whether this is okay. It is conceivably breaking for people who rely on printing the model to a string, even if they really shouldn't be doing that.
One justification for doing this is that we added #3575 and I haven't heard any complaints, and it is pretty easy to suddenly spam a lot of content to stdout if your model is large.