Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] mention extensions in relevant tutorials #3625

Merged
merged 7 commits into from
Dec 13, 2023
Merged

[docs] mention extensions in relevant tutorials #3625

merged 7 commits into from
Dec 13, 2023

Conversation

odow
Copy link
Member

@odow odow commented Dec 12, 2023

x-ref #3623 (comment)

I think the rule for this is that the extension must be part of the Extensions tab of the JuMP docs, and we must link there. That means if we ever remove an extension from the docs, it'll also catch removing these links.

@odow odow mentioned this pull request Dec 12, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e2e263) 98.21% compared to head (3bd428b) 98.21%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3625   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          43       43           
  Lines        5653     5653           
=======================================
  Hits         5552     5552           
  Misses        101      101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Dec 12, 2023

I never get these relative links correct

@odow @mortenpi
Apply suggestions from code review
3bd428b 
Co-authored-by: Morten Piibeleht <[email protected]>
@odow odow changed the base branch from master to odow-patch-2 December 13, 2023 05:13
@odow odow merged commit 4dfd1a7 into odow-patch-2 Dec 13, 2023
12 checks passed
@odow odow deleted the odow-patch-3 branch December 13, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @mortenpi