Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add DisjunctiveProgramming #3598

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[docs] add DisjunctiveProgramming #3598

merged 4 commits into from
Dec 12, 2023

Conversation

odow
Copy link
Member

@odow odow commented Dec 6, 2023

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cecc5ba) 98.39% compared to head (08c0f9e) 97.69%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   98.39%   97.69%   -0.71%     
==========================================
  Files          38       43       +5     
  Lines        5687     5638      -49     
==========================================
- Hits         5596     5508      -88     
- Misses         91      130      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher
Copy link
Contributor

Thanks @odow, I suspected this wouldn't quite work. I think the best way forward would be for me to make a JuMP specific readme like I did for InfiniteOpt. I should have time to do that this week.

@joaquimg
Copy link
Member

joaquimg commented Dec 6, 2023

Another option would be to cleanup the readme since most of it is replicated in the docs.

@pulsipher
Copy link
Contributor

Another option would be to cleanup the readme since most of it is replicated in the docs.

This along with improving the docs is on my TODO list, I just need to find the time :)

@pulsipher
Copy link
Contributor

I think I fixed the vale errors

docs/packages.toml Outdated Show resolved Hide resolved
docs/packages.toml Outdated Show resolved Hide resolved
@pulsipher
Copy link
Contributor

Hold off on merging, I found a few typos I should correct first...

@odow
Copy link
Member Author

odow commented Dec 12, 2023

Typos that vale didn't catch? Interesting

@odow
Copy link
Member Author

odow commented Dec 12, 2023

Merging because we can always update later. I don't see the typos @pulsipher is talking about.

@odow odow merged commit 5b1a53f into master Dec 12, 2023
11 of 12 checks passed
@odow odow deleted the odow-patch-1 branch December 12, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants