-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] document how to support operators with several vector arguments #3577
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3577 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 37 38 +1
Lines 5629 5648 +19
=======================================
+ Hits 5538 5557 +19
Misses 91 91 ☔ View full report in Codecov by Sentry. |
It might be more helpful to show how to deal with functions that cannot be traced and to show how to also get the derivative info with AD and pass it to |
Co-authored-by: Benoît Legat <[email protected]>
Is this part not sufficient? https://jump.dev/JuMP.jl/stable/manual/nonlinear/#Multivariate-functions |
It doesn't say that you can use AD |
I'd rather not encourage people. We can already use ForwardDiff automatically. If anyone has a user-defined operator and wants to use a custom AD that isn't ForwardDiff, then I expect them to be very advanced users who can figure it out based on the signature of If we tell people to use Enzyme/Zygote/ReverseDiff.jl then we'll have to deal with the questions and quirks. |
This is good enough for now. A question of whether to add a third-party AD example is best left for a different PR. I'll make a note in the issue. |
Closes #3576