Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable_ref_type for unsupported types and GenericNonlinearExpr #3556

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

odow
Copy link
Member

@odow odow commented Nov 1, 2023

Closes #3555

test/test_variable.jl Outdated Show resolved Hide resolved
src/variables.jl Outdated Show resolved Hide resolved
test/test_variable.jl Outdated Show resolved Hide resolved
test/test_variable.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (908275f) 98.19% compared to head (ae29edd) 98.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3556      +/-   ##
==========================================
+ Coverage   98.19%   98.37%   +0.17%     
==========================================
  Files          37       37              
  Lines        5599     5603       +4     
==========================================
+ Hits         5498     5512      +14     
+ Misses        101       91      -10     
Files Coverage Δ
src/nlp_expr.jl 99.52% <100.00%> (+0.47%) ⬆️
src/variables.jl 99.02% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 0cd6a03 into master Nov 2, 2023
11 checks passed
@odow odow deleted the od/variable-ref-type branch November 2, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

variable_ref_type induces StackOverFlowError
1 participant