Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PolyJuMP KKT and QCQP solvers #3545

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add PolyJuMP KKT and QCQP solvers #3545

merged 3 commits into from
Oct 20, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 18, 2023

We could debate whether it should be two of one rows since they both live in the same package. However, they are really two different solvers, the only thing they share is that they supports ScalarPolynomialFunction constraints so I think it's really two rows.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7b5789) 98.18% compared to head (2b342ae) 98.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3545   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          37       37           
  Lines        5578     5578           
=======================================
  Hits         5477     5477           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Oct 19, 2023

I don't really have an opinion. I'm okay with either.

We could/should also update the extension: https://jump.dev/JuMP.jl/previews/PR3545/packages/PolyJuMP/

But it's okay if I do this in a separate PR.

@blegat
Copy link
Member Author

blegat commented Oct 19, 2023

Good point, I bumped it here

@odow
Copy link
Member

odow commented Oct 19, 2023

I guess I need to figure out how to change the vale error threshold for pages in the package directory.

@odow odow merged commit 12ffa91 into master Oct 20, 2023
10 of 11 checks passed
@odow odow deleted the bl/kkt_qcqp branch October 20, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants