Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a+im*b to complex(a,b) #840

Merged
merged 4 commits into from
May 13, 2024
Merged

Change a+im*b to complex(a,b) #840

merged 4 commits into from
May 13, 2024

Conversation

araujoms
Copy link
Contributor

This undoes the hack I had done in #831, thanks to jump-dev/JuMP.jl#3734.

@araujoms
Copy link
Contributor Author

Yeah the examples won't run until the next version of JuMP is released, perhaps it's better to wait for that before merging this PR.

@odow
Copy link
Member

odow commented Apr 18, 2024

You must also change the lower bound of JuMP in any Project.tomls

@araujoms
Copy link
Contributor Author

That's not possible, JuMP is not a dependency of Hypatia, it's only used in the examples.

@odow
Copy link
Member

odow commented Apr 18, 2024

Then a separate issue is https://github.com/jump-dev/Hypatia.jl/blob/master/examples/Project.toml
is missing a [compat] section.

@araujoms
Copy link
Contributor Author

Oh, thanks for finding it! I'll add the necessary [compat] then when we have the new version of JuMP.

@araujoms
Copy link
Contributor Author

Now with JuMP 1.22 it's working. Could you also tag a new Hypatia release?

@odow odow merged commit 1298b2d into jump-dev:master May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants