Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace SuiteSparse_long with the type of Sys.WORD_SIZE #828

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

ven-k
Copy link
Contributor

@ven-k ven-k commented Nov 6, 2023

  • SuiteSparse_long is dropped in Julia 1.10. See1

Footnotes

  1. https://github.com/JuliaSparse/SparseArrays.jl/pull/408/files

- `SuiteSparse_long` is dropped in Julia 1.10
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f81cf2) 96.38% compared to head (c0c122f) 96.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   96.38%   96.76%   +0.37%     
==========================================
  Files          56       56              
  Lines        8971     8971              
==========================================
+ Hits         8647     8681      +34     
+ Misses        324      290      -34     
Files Coverage Δ
src/linearalgebra/sparse.jl 87.17% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanmg
Copy link
Contributor

Would be good to see this merged. It's easy to fix locally of course.

@lkapelevich
Copy link
Collaborator

@stephanmg looks like a a build failed because https://github.com/chriscoey/Hypatia.jl/blob/master/examples/contraction/JuMP.jl needs an update DP.Polyvar->DP.Variable. Would you like to make the change?

@stephanmg
Copy link
Contributor

@lkapelevich pardon me. I'm fairly new to the Julia ecosystem, I'm afraid I would leave this to the maintainers of the respective packages. FWIW I could make Hypatia.jl locally work, so I guess it's not a big deal.

@lkapelevich lkapelevich merged commit 119e43a into jump-dev:master Nov 25, 2023
5 of 6 checks passed
@odow odow mentioned this pull request Dec 30, 2023
@thchr
Copy link

thchr commented Jan 12, 2024

Can a new version of Hypatia.jl be tagged please? It currently throws during precompile due to the issue fixed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants