Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of haskey lookups #246

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Improve performance of haskey lookups #246

merged 6 commits into from
Nov 1, 2024

Conversation

odow
Copy link
Member

@odow odow commented Oct 31, 2024

We call _info a lot. The previous code did a hash lookup twice. Once to checkin the key existed (the most common case), and then once to get the actual value. This simplifies the code to a single hash lookup.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (1a4f551) to head (ea220b8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   99.77%   99.78%           
=======================================
  Files           1        1           
  Lines        1352     1382   +30     
=======================================
+ Hits         1349     1379   +30     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/MOI_wrapper.jl Outdated Show resolved Hide resolved
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@odow odow merged commit 3a61244 into master Nov 1, 2024
10 checks passed
@odow odow deleted the od/haskey branch November 1, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant