Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flips signs of quadslack for maximization, fixes 142 #150

Merged
merged 2 commits into from
Oct 3, 2022
Merged

flips signs of quadslack for maximization, fixes 142 #150

merged 2 commits into from
Oct 3, 2022

Conversation

LukasBarner
Copy link
Contributor

@LukasBarner LukasBarner commented Oct 3, 2022

fixes #142

@joaquimg
Copy link
Member

joaquimg commented Oct 3, 2022

@LukasBarner can you fix format so that we can merge?

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 93.00% // Head: 94.58% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (69b499a) compared to base (b9d2581).
Patch has no changes to coverable lines.

❗ Current head 69b499a differs from pull request most recent head 84bac98. Consider uploading reports for the commit 84bac98 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.00%   94.58%   +1.58%     
==========================================
  Files          12       12              
  Lines         672      702      +30     
==========================================
+ Hits          625      664      +39     
+ Misses         47       38       -9     
Impacted Files Coverage Δ
src/dual_equality_constraints.jl 91.72% <ø> (+0.67%) ⬆️
src/utils.jl 100.00% <0.00%> (ø)
src/dual_sets.jl 100.00% <0.00%> (ø)
src/dual_names.jl 75.00% <0.00%> (ø)
src/structures.jl 100.00% <0.00%> (ø)
src/constrained_variables.jl 100.00% <0.00%> (ø)
src/add_dual_cone_constraint.jl 100.00% <0.00%> (ø)
src/objective_coefficients.jl 98.07% <0.00%> (+0.16%) ⬆️
src/MOI_wrapper.jl 92.65% <0.00%> (+0.25%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LukasBarner
Copy link
Contributor Author

OK, think I have this fixed as well now :D

@joaquimg joaquimg merged commit e5f57b1 into jump-dev:master Oct 3, 2022
@LukasBarner LukasBarner deleted the max_min_quad branch October 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug for Dualization of Maximization Problems
2 participants