Fix right-multiply bug, add simple test (#280)

jump-dev · Mar 25, 2019 · 5d7ece3 · 5d7ece3
1 parent 7f11002
commit 5d7ece3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/atoms/affine/multiply_divide.jl b/src/atoms/affine/multiply_divide.jl
@@ -86,7 +86,7 @@ function conic_form!(x::MultiplyAtom, unique_conic_forms::UniqueConicForms=Uniqu
         # right matrix multiplication
         else
             objective = conic_form!(x.children[1], unique_conic_forms)
-            objective = kron(x.children[2].value', sparse(1.0I, x.size[1], x.size[1])) * objective
+            objective = kron(transpose(x.children[2].value), sparse(1.0I, x.size[1], x.size[1])) * objective
         end
         cache_conic_form!(unique_conic_forms, x, objective)
     end

diff --git a/test/test_affine.jl b/test/test_affine.jl
@@ -47,6 +47,12 @@
         @test vexity(p) == AffineVexity()
         solve!(p, solver)
         @test p.optval ≈ 3 atol=TOL
+
+        # Check #274
+        x = ComplexVariable(2,2)
+        p = minimize( real( [1.0im, 0.0]' * x * [1.0im, 0.0] ), [ x == [1.0 0.0; 0.0 1.0] ])
+        solve!(p, solver)
+        @test p.optval ≈ 1.0
     end
 
     @testset "dot atom" begin