Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add architecture constraints #25

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

juliusstoerrle
Copy link
Owner

Here a proposal to add architecture checks using https://www.phpat.dev/, executed as phpstan extension.

Checks are seperated in:

  • HighLevelArchitecture, some basic checks, basically on the structure of our namespaces
  • CoreDomainLayers, limiting which components inside core can depend on others
  • NamingConventions to enforce a pattern language

Currently checks are limited as component names are not finalised. Any checks besides those in the core that should be established?

  • Add phpat to composer.lock file

@juliusstoerrle
Copy link
Owner Author

Potential checks within Core?

  • Services only on model
  • Services using interfaces
  • Commands, events are POPOs

Checks within View:

  • Controller using __invoke & Route Attribute
  • Forms nicht auf Controller
  • Requests nicht auf Form oder Controller -> POPO

@juliusstoerrle juliusstoerrle marked this pull request as draft January 9, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant