Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc improvements #629

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Doc improvements #629

merged 3 commits into from
Nov 14, 2024

Conversation

hmlanigan
Copy link
Member

@hmlanigan hmlanigan commented Nov 13, 2024 •
edited
Loading

Description

Various documentation updates

Type of change

  • Other: documentation updates

alesstimec
alesstimec approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick a moan about JuJu vs Juju capitalization.

docs/resources/credential.md Outdated Show resolved Hide resolved
@hmlanigan
docs: add info on which schema attributes will cause delete create
c7a9b4b 
Add to the schema attribute descriptions which changes will cause
terraform to destroy and recreate a resource.
@hmlanigan
docs: update offer_url use in integration resource
a31d122 
Per juju#449, indicate that offer_url and name/endpoint are mutually
exclusive in an integration resource.
@hmlanigan
docs: add warning to application template for config
bef5faf 
Requested in GH issue juju#393.
@hmlanigan
Copy link
Member Author

/merge

1 similar comment
@hmlanigan
Copy link
Member Author

/merge

@jujubot jujubot merged commit b0a8fe4 into juju:main Nov 14, 2024
26 of 31 checks passed
@hmlanigan hmlanigan deleted the doc-improvements branch November 15, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesstimec alesstimec alesstimec approved these changes

@anvial anvial Awaiting requested review from anvial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmlanigan @alesstimec @jujubot