chore(makefile): create check makefile target #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
jack-w-shaw
commented
Jul 23, 2024
| @@ -101,5 +101,4 @@ install-snap-dependencies: check-snap-package | |||
| install-dependencies: install-snap-dependencies | |||
| ## install-dependencies: Install all the dependencies | |||
|
|
|||
|
|
|||
|
|
|||
| check: juju-unit-test | |||
There was a problem hiding this comment.
@hmlanigan juju-unit-test seems to be quite a lightweight test suite.
Shall we put something else here? Or is this good for now? What do you think?
There was a problem hiding this comment.
Imo best option should be to keep it light in Jenkins, and make more github actions required
There was a problem hiding this comment.
This set of tests will get bigger over time, but okay for now.
|
/merge |
hmlanigan
approved these changes
Jul 23, 2024
| @@ -101,5 +101,4 @@ install-snap-dependencies: check-snap-package | |||
| install-dependencies: install-snap-dependencies | |||
| ## install-dependencies: Install all the dependencies | |||
|
|
|||
|
|
|||
|
|
|||
| check: juju-unit-test | |||
There was a problem hiding this comment.
This set of tests will get bigger over time, but okay for now.
|
/merge |
The check target is a special target used in our CI. This should allow our default Jenkins jobs to correctly run our unit tests and merge
hmlanigan
force-pushed
the
JUJU-4184_tf_check_job
branch
from
f3495d6
to
01a4dd9
Compare
|
Need a signed commit to merge, and unblock other PRs which now need the check make target. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check target is a special target used in our CI.
This should allow our default Jenkins jobs to correctly run our unit tests and merge
Type of change
QA steps
commenting
/buildor/mergecorrectly trigger jenkins jobs