chore: pull types from wip PR for upcoming Model.wait_for_idle #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-garner-canonical
requested changes
Nov 20, 2024
dimaqq
force-pushed
the
chore-type-hints-for-wait-for-idle
branch
from
43d1935 to
99d8fc1
Compare
|
re self._info, pls reload |
james-garner-canonical
approved these changes
Nov 22, 2024
|
I'll need to either wait for canonical/pylxd#615 Or rip out the tox.ini and deps changes and chuck them aside... to a separate PR. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve type hints.
Sourced from #1104
These type hints will be used to upstream the new wait_for_idle()