Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta/backup: fix slice conflict #5361

Merged
merged 3 commits into from
Dec 11, 2024
Merged

meta/backup: fix slice conflict #5361

merged 3 commits into from
Dec 11, 2024

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Dec 11, 2024 •
edited
Loading

  1. A new slice is needed as concurrent operations might still use the same slice.
  2. Batch size for xattr is already limited at the outer layer.

@jiefenghuang
meta/redis: fix backup
50919df 
Signed-off-by: jiefenghuang <[email protected]>
@jiefenghuang jiefenghuang requested a review from davies December 11, 2024 02:19
@jiefenghuang jiefenghuang changed the title meta/redis: fix backup meta/backup: fix slice conflict Dec 11, 2024
@jiefenghuang
sql: remove unused
b2e3ba0 
Signed-off-by: jiefenghuang <[email protected]>
@jiefenghuang
sql: fix reused slice
537819d 
Signed-off-by: jiefenghuang <[email protected]>
@davies davies merged commit d1c00a8 into main Dec 11, 2024
35 checks passed
@davies davies deleted the fix-redis-backup branch December 11, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies davies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiefenghuang @davies