Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/sql: support new backup #5344

Merged
merged 4 commits into from
Dec 5, 2024
Merged

meta/sql: support new backup #5344

merged 4 commits into from
Dec 5, 2024

Conversation

jiefenghuang
Copy link
Contributor

No description provided.

@jiefenghuang jiefenghuang requested a review from SandyXSD December 4, 2024 09:00
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 2.08711% with 1079 lines in your changes missing coverage. Please review.

Project coverage is 23.21%. Comparing base (450d0de) to head (9f45e5b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/meta/sql_bak.go 0.00% 688 Missing ⚠️
pkg/meta/backup.go 10.74% 191 Missing ⚠️
pkg/meta/base.go 0.00% 102 Missing ⚠️
pkg/meta/sql.go 0.00% 75 Missing ⚠️
pkg/meta/tkv_bak.go 0.00% 12 Missing ⚠️
pkg/meta/redis_bak.go 0.00% 9 Missing ⚠️
pkg/meta/tkv.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5344       +/-   ##
===========================================
- Coverage   54.90%   23.21%   -31.69%     
===========================================
  Files         161       29      -132     
  Lines       44415    17589    -26826     
===========================================
- Hits        24384     4083    -20301     
+ Misses      17357    13021     -4336     
+ Partials     2674      485     -2189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jiefenghuang <[email protected]>
@jiefenghuang jiefenghuang force-pushed the feat/sql-bakcup branch 2 times, most recently from 9f45e5b to c566761 Compare December 5, 2024 03:22
Signed-off-by: jiefenghuang <[email protected]>
pkg/meta/backup.go Outdated Show resolved Hide resolved
pkg/meta/redis_bak.go Outdated Show resolved Hide resolved
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
@davies
Copy link
Contributor

davies commented Dec 5, 2024

LGTM, merging now.

@davies davies merged commit 607ec6f into main Dec 5, 2024
39 checks passed
@davies davies deleted the feat/sql-bakcup branch December 5, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants