Multipart upload fully obeys keep-etag config #5338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changxin Miao <[email protected]>
davies
reviewed
Dec 4, 2024
| @@ -1027,7 +1030,7 @@ func (n *jfsObjects) PutObjectPart(ctx context.Context, bucket, object, uploadID | |||
| var etag string | |||
| if err = n.putObject(ctx, bucket, p, r, opts, func(tmpName string) { | |||
| etag = r.MD5CurrentHexString() | |||
| if n.fs.SetXattr(mctx, tmpName, s3Etag, []byte(etag), 0) != 0 { | |||
| if n.gConf.KeepEtag && n.fs.SetXattr(mctx, tmpName, s3Etag, []byte(etag), 0) != 0 { | |||
There was a problem hiding this comment.
I think we should keep this, and verify that in CompleteMultipartUpload
There was a problem hiding this comment.
OK, I will keep the code as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current code - when
keep-etagis disabled (by default), they are saved but never used.juicefs/pkg/gateway/gateway.go
Lines 1082 to 1085 in b63efb6