Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor metrics updates #4587

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Two minor metrics updates #4587

merged 1 commit into from
Mar 26, 2024

Conversation

polyrabbit
Copy link
Contributor

  1. Export version into metrics label - useful when we are upgrading a cluster of hundreds of nodes, it provides an overview of upgrade process.

  2. Export the uploading objects number - so we will know whether we are running out of max-uploads.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (11d436e) to head (02a52c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4587      +/-   ##
==========================================
- Coverage   55.65%   55.63%   -0.03%     
==========================================
  Files         158      158              
  Lines       43101    43109       +8     
==========================================
- Hits        23990    23985       -5     
- Misses      16446    16451       +5     
- Partials     2665     2673       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SandyXSD SandyXSD requested a review from zhijian-pro March 26, 2024 12:48
@davies davies merged commit 818f10f into juicedata:main Mar 26, 2024
32 checks passed
@polyrabbit polyrabbit deleted the version-metric branch March 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants