Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for chunk compaction #4585

Merged
merged 5 commits into from
Apr 3, 2024
Merged

refactor for chunk compaction #4585

merged 5 commits into from
Apr 3, 2024

Conversation

davies
Copy link
Contributor

@davies davies commented Mar 26, 2024

No description provided.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 75.59809% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 55.43%. Comparing base (b46fac4) to head (20ff35b).
Report is 14 commits behind head on main.

Files Patch % Lines
pkg/meta/base.go 83.46% 14 Missing and 7 partials ⚠️
pkg/meta/sql.go 59.45% 10 Missing and 5 partials ⚠️
pkg/meta/redis.go 57.69% 6 Missing and 5 partials ⚠️
pkg/meta/tkv.go 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4585      +/-   ##
==========================================
- Coverage   55.54%   55.43%   -0.11%     
==========================================
  Files         159      159              
  Lines       42940    42773     -167     
==========================================
- Hits        23849    23713     -136     
+ Misses      16431    16416      -15     
+ Partials     2660     2644      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/meta/redis.go Outdated Show resolved Hide resolved
pkg/meta/base.go Show resolved Hide resolved
@davies davies merged commit 926768c into main Apr 3, 2024
32 checks passed
@davies davies deleted the compact_refactor branch April 3, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants