Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump: add --threads=10 for dump #4581

Merged
merged 3 commits into from
Mar 26, 2024
Merged

dump: add --threads=10 for dump #4581

merged 3 commits into from
Mar 26, 2024

Conversation

davies
Copy link
Contributor

@davies davies commented Mar 26, 2024

No description provided.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.65%. Comparing base (346b068) to head (f8c58de).
Report is 5 commits behind head on main.

❗ Current head f8c58de differs from pull request most recent head 338f0e6. Consider uploading reports for the commit 338f0e6 to get more accurate results

Files Patch % Lines
cmd/dump.go 54.54% 3 Missing and 2 partials ⚠️
pkg/vfs/backup.go 62.50% 2 Missing and 1 partial ⚠️
pkg/meta/redis.go 81.81% 0 Missing and 2 partials ⚠️
pkg/meta/sql.go 81.81% 0 Missing and 2 partials ⚠️
pkg/meta/tkv.go 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4581      +/-   ##
==========================================
- Coverage   55.66%   55.65%   -0.01%     
==========================================
  Files         158      158              
  Lines       43067    43078      +11     
==========================================
+ Hits        23972    23977       +5     
+ Misses      16436    16435       -1     
- Partials     2659     2666       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies requested a review from SandyXSD March 26, 2024 08:00
cmd/dump.go Outdated
@@ -109,7 +114,12 @@ func dump(ctx *cli.Context) (err error) {
if st := m.Chroot(meta.Background, metaConf.Subdir); st != 0 {
return st
}
if err := m.DumpMeta(w, 1, ctx.Bool("keep-secret-key"), ctx.Bool("fast"), ctx.Bool("skip-trash")); err != nil {
threads := ctx.Int("threads")
if threads < 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<=

@davies davies merged commit 41e2071 into main Mar 26, 2024
26 of 27 checks passed
@davies davies deleted the dump_threads branch March 26, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants