assign default values to the trash node #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
==========================================
- Coverage 55.66% 55.65% -0.01%
==========================================
Files 158 158
Lines 43067 43076 +9
==========================================
+ Hits 23972 23976 +4
- Misses 16436 16437 +1
- Partials 2659 2663 +4 ☔ View full report in Codecov by Sentry. |
|
also sql and redis? |
davies
reviewed
Mar 26, 2024
| @@ -3323,6 +3323,16 @@ func (m *kvMeta) DumpMeta(w io.Writer, root Ino, keepSecret, fast, skipTrash boo | |||
| tree = m.snap[root] | |||
| if !skipTrash { | |||
| trash = m.snap[TrashInode] | |||
| if trash == nil { | |||
There was a problem hiding this comment.
When this happen? It's OK to have no trash.
There was a problem hiding this comment.
Uniform behavior is for easier testing.
Other engines don't have this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the trash node does not exist, give it a default value.