fix password leakage problem when password contains @ symbol (#4071)

juicedata · Sep 27, 2023 · cda20c6 · cda20c6
1 parent 0314e38
commit cda20c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go
@@ -119,7 +119,7 @@ func WithTimeout(f func() error, timeout time.Duration) error {
 }
 
 func RemovePassword(uri string) string {
-	p := strings.Index(uri, "@")
+	p := strings.LastIndex(uri, "@")
 	if p < 0 {
 		return uri
 	}

diff --git a/pkg/utils/utils_test.go b/pkg/utils/utils_test.go
@@ -94,6 +94,9 @@ func TestRemovePassword(t *testing.T) {
 		{"redis://:password@localhost:6379/0",
 			"redis://:****@localhost:6379/0",
 		},
+		{"redis://:pass@word@localhost:6379/0",
+			"redis://:****@localhost:6379/0",
+		},
 		{":password@localhost:6379/0",
 			":****@localhost:6379/0",
 		},