Skip to content

Commit

Permalink
chore: fix some comments (#4566)
Browse files Browse the repository at this point in the history
Signed-off-by: occupyhabit <[email protected]>
  • Loading branch information
occupyhabit authored Mar 24, 2024
1 parent 49ea79e commit 4fb1c98
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/en/community/adopters.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ slug: /adopters
| [Horizon Robotics](https://horizon.ai) | Production | AI | |
| [SenseTime](https://www.sensetime.com/en) | Production | File Sharing | |
| [DP Technology](https://www.dp.tech) | Production | AI | [AI & HPC Workloads on Hybrid Cloud: Storage Challenges and Solutions](https://juicefs.com/en/blog/user-stories/storage-architectures-for-ai-hpc-in-hybridmulti-cloud) |
| [Joyient](http://www.joyient.com) | Prodcution | File Sharing, VFX Rendering | |
| [Joyient](http://www.joyient.com) | Production | File Sharing, VFX Rendering | |
| [DJI](https://www.dji.com) | Production | AI | |
| [Kingsoft Cloud](https://en.ksyun.com) | Production | Big Data | [Storing Elasticsearch Warm/Cold Data on Object Storage with JuiceFS: A Guide by Kingsoft Cloud](https://juicefs.com/en/blog/user-stories/kingsoft-cloud-how-to-store-elasticsearch-data-in-objective-storage-with-juicefs) |
| [Skyplatanus](https://www.kuaidianyuedu.com) | Production | AI, File Sharing | |
Expand Down
2 changes: 1 addition & 1 deletion docs/en/deployment/hadoop_java_sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ First you need to add JuiceFS SDK to `classpath` in Kafka Connect, e.g., `/usr/s

While creating a Connect Sink task, configuration needs to be set up as follows:

- Specify `hadoop.conf.dir` as the directory that contains the configuration file `core-site.xml`. If it is not running in Hadoop environment, you can create a seperate directory such as `/usr/local/juicefs/hadoop`, and then add the JuiceFS related configurations to `core-site.xml`.
- Specify `hadoop.conf.dir` as the directory that contains the configuration file `core-site.xml`. If it is not running in Hadoop environment, you can create a separate directory such as `/usr/local/juicefs/hadoop`, and then add the JuiceFS related configurations to `core-site.xml`.
- Specify `store.url` as a path starting with `jfs://`.

For example:
Expand Down
2 changes: 1 addition & 1 deletion docs/en/guide/cache.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Caching these metadata in kernel for 1 second really speeds up `lookup` and `get

Do note that `entry` cache is gradually built upon file access and may not contain a complete file list under directory, so `readdir` calls or `ls` command cannot utilize this cache, that's why `entry` cache only improves `lookup` performance. The meaning of `direntry` here is different from [kernel directory entry](https://www.kernel.org/doc/html/latest/filesystems/ext4/directory.html), `direntry` does not tell you the files under a directory, but rather, it's the same concept as `entry`, just distinguished based on whether it's a directory.

Real world scenarios scarcely require setting different values for `--entry-cache` and `--dir-entry-cache`, these options exist for theoretical possibilities like when directories seldomly change while files change a lot, in that situation, you can use a higher `--dir-entry-cache` than `--entry-cache`.
Real world scenarios scarcely require setting different values for `--entry-cache` and `--dir-entry-cache`, these options exist for theoretical possibilities like when directories seldom change while files change a lot, in that situation, you can use a higher `--dir-entry-cache` than `--entry-cache`.

### Metadata cache in client memory {#client-memory-metadata-cache}

Expand Down
2 changes: 1 addition & 1 deletion pkg/meta/base_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ func testLocks(t *testing.T, m Meta) {
time.Sleep(time.Millisecond)
count--
if count > 0 {
panic(fmt.Errorf("count should be be zero but got %d", count))
panic(fmt.Errorf("count should be zero but got %d", count))
}
if st := m.Setlk(ctx, inode, uint64(i), false, syscall.F_UNLCK, 0, 0xFFFF, uint32(i)); st != 0 {
panic(fmt.Errorf("plock unlock: %s", st))
Expand Down

0 comments on commit 4fb1c98

Please sign in to comment.