Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TLS crash by removing obsolete twitter-stream patch #140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix TLS crash by removing obsolete twitter-stream patch #140

wants to merge 3 commits into from

Commits on Jun 11, 2016

  1. Fix user stream endpoint URLs

    @frasertweedale
    frasertweedale committed Jun 11, 2016
    Configuration menu
    Copy the full SHA
    0afebc0 View commit details
    Browse the repository at this point in the history

  2. fix TLS crash by removing obsolete twitter-stream patch 

    earthquake is working around an issue in old releases of
twitter-stream where reconnections were not honouring
@options[:ssl].

This issue was fixed in twitter-stream-0.1.15, and the now
unnecessary monkey-patch crashes the program upon reconnect.

Require twitter-stream ~> 0.1.15 and remove the monkey-patch
to make the crashes go away.
    @frasertweedale
    frasertweedale committed Jun 11, 2016
    Configuration menu
    Copy the full SHA
    e348e4e View commit details
    Browse the repository at this point in the history

  3. use twitter-stream's reconnect-on-timeout behaviour 

    twitter-stream ~> 0.1.16 takes care of reconnecting when no data has
been received for a while.  With earthquake also doing this, strange
behaviour occurs when twitter-stream 0.1.16 is used.

Update the dependency to twitter-stream ~> 0.1.16 and remove the
reconnect-on-timeout code from Earthquake::Core to restore normal
behaviour.
    @frasertweedale
    frasertweedale committed Jun 11, 2016
    Configuration menu
    Copy the full SHA
    3ec8534 View commit details
    Browse the repository at this point in the history