fix: Allow customizing the rake task regex to avoid starting the reporter

[adamlogic]

Fixes #219

Before adding config.rake_task_ignore_regex = /assets:|db:|middleware/ to the sample app:

rails-sample $ rails middleware
[Judoscale] Reporter starting, will report every ~10 seconds (adapters: judoscale-rails, judoscale-ruby[skipped])
[Judoscale] Reporting 0 metrics
use ActionDispatch::HostAuthorization
use Rack::Sendfile
...

After adding config.rake_task_ignore_regex = /assets:|db:|middleware/ to the sample app:

rails-sample $ rails middleware
[Judoscale] No reporting since we're in a build process
use ActionDispatch::HostAuthorization
use Rack::Sendfile
...

[carlosantoniodasilva]

Looks good, had a small suggestion and also there seems to be some issue with standard and different Ruby versions we might need to tackle.

[carlosantoniodasilva]

It looks like Ruby 2.x didn't like this change... it appears they consider interpolated strings as frozen, whereas 3+ doesn't: (which is probably why standard/rubocop suggested it?)

% chruby 3.3.4

% ruby --enable-frozen-string-literal -e 'puts [RUBY_VERSION, "foo".frozen?, "#{%q(zomg)}".frozen?].inspect'
["3.3.4", true, false]

% chruby 2.7.8

% ruby --enable-frozen-string-literal -e 'puts [RUBY_VERSION, "foo".frozen?, "#{%q(zomg)}".frozen?].inspect'
["2.7.8", true, true]

I'm not sure I have a good suggestion that doesn't include a check on RUBY_VERSION to dup the string for now... (or always dup it and leave a note about when dropping older versions or something)

[adamlogic]

The RedundantInterpolationUnfreeze check was literally added to standard two days ago and subsequently released in 1.41.0.

Another approach here is to leave our code as it was before this PR, and lock our lint GH Action to gem install standardrb -v '~> 1.40.0'.

[adamlogic]

Drafted a fix in #221.

[carlosantoniodasilva]

This might be more Rails specific than Ruby specific, I guess, since it's only something we use there... maybe we should only expose it within Rails, like we have start_reporter_after_initialize?

judoscale-ruby/judoscale-rails/lib/judoscale/rails/config.rb

Lines 4 to 6 in 92a34b9

	module Rails
	module Config
	attr_accessor :start_reporter_after_initialize

(btw, it does make me wonder if we should have config.rails.foo like we have with the background workers, but that's probably another topic for discussion)

[adamlogic]

Good call! I'm moving this to be Rails-specific.

[carlosantoniodasilva]

Does it seem that "middleware" is default enough to warrant we skipping that by default as well? Or do you think we could run into some unexpected issue if we were to add it now?

[adamlogic]

I don't think we'd run into any issues by including middleware by default, but for now I think I'd rather leave it out. It's not typically run in build processes or prod environments, and it's a quick task as opposed to a task that could take a while.

I don't think our default rake_task_ignore_regex needs to be exhaustive. The goal is really to avoid starting the reporter during common build processes.

[carlosantoniodasilva]

Gotcha, sounds good.

[carlosantoniodasilva]

Approved by mistake.

[carlosantoniodasilva]

[carlosantoniodasilva]

Gotcha, sounds good.