Skip to content

Commit

Permalink
Fix typos (#47)
Browse files Browse the repository at this point in the history
* Fix typos.
* Use Mambaforge.
  • Loading branch information
jtilly authored Feb 11, 2023
1 parent d0bb8d0 commit 8ca4820
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 16 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ jobs:
name: CI
runs-on: "ubuntu-latest"
steps:
- uses: actions/checkout@v2
- uses: conda-incubator/setup-miniconda@v2
- uses: actions/checkout@v3
- uses: conda-incubator/setup-miniconda@v2.2.0
with:
python-version: 3.9
mamba-version: "*"
channels: conda-forge,r,defaults
channel-priority: true
miniforge-version: latest
miniforge-variant: Mambaforge
channels: conda-forge
- shell: bash -l {0}
run: |
conda info
Expand Down
2 changes: 1 addition & 1 deletion R/RcppExports.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#' listed as being matched to \code{m}.}
#' \item{\code{engagements} is a vector of length \code{m} whose \code{j}th
#' element contains the number of the proposer that reviewer \code{j} is
#' matched to using C++ indexing. Reviwers that remain unmatched will be
#' matched to using C++ indexing. Reviewers that remain unmatched will be
#' listed as being matched to \code{n}.}
#' }
#' @export
Expand Down
2 changes: 1 addition & 1 deletion R/galeshapley.R
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
#' matched to \code{NA}.}
#' \item{\code{engagements} is a vector of length \code{m} whose \code{j}th
#' element contains the number of the proposer that reviewer \code{j} is
#' matched to. Reviwers that remain unmatched will be listed as being matched
#' matched to. Reviewers that remain unmatched will be listed as being matched
#' to \code{NA}.}
#' \item{\code{single.proposers} is a vector that lists the remaining single
#' proposers. This vector will be empty whenever \code{n<=m}}.
Expand Down
5 changes: 2 additions & 3 deletions environment.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
name: matchingR
channels:
- conda-forge
- r
- nodefaults
dependencies:
- r-rcpp
- r-base=4.2
- r-rcpp
- r-rcpparmadillo
- r-testthat
- r-knitr
Expand Down
2 changes: 1 addition & 1 deletion man/cpp_wrapper_galeshapley.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/galeShapley.marriageMarket.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/galeshapley.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
//' listed as being matched to \code{m}.}
//' \item{\code{engagements} is a vector of length \code{m} whose \code{j}th
//' element contains the number of the proposer that reviewer \code{j} is
//' matched to using C++ indexing. Reviwers that remain unmatched will be
//' matched to using C++ indexing. Reviewers that remain unmatched will be
//' listed as being matched to \code{n}.}
//' }
//' @export
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test_galeshapley.R
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ test_that("Check if galeShapley.collegeAdmissions matching returns the same resu
expect_true(identical(matching1, matching2))
})

test_that("Check student-optimal galeShapley.collegeAdmissions with differnet numbers of slots", {
test_that("Check student-optimal galeShapley.collegeAdmissions with different numbers of slots", {

# four students, two colleges, slots c(1,2)
uStudents <- matrix(runif(8), nrow = 2, ncol = 4)
Expand All @@ -257,7 +257,7 @@ test_that("Check student-optimal galeShapley.collegeAdmissions with differnet nu
expect_equal(matching1$matched.students, matching2$proposals)
})

test_that("Check college-optimal galeShapley.collegeAdmissions with differnet numbers of slots", {
test_that("Check college-optimal galeShapley.collegeAdmissions with different numbers of slots", {

# four students, two colleges, slots c(1,2)
uStudents <- matrix(runif(8), nrow = 2, ncol = 4)
Expand Down

0 comments on commit 8ca4820

Please sign in to comment.