Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change broken selection in enable_button_after parameter #3364

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

levigoldberg
Copy link

The button class was not being selected correctly resulting in a broken enable_button_after parameter

The button class was not being selected correctly resulting in a broken enable_button_after parameter
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: fe53143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jspsych/plugin-html-button-response Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@jadeddelta jadeddelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levigoldberg great catch, LGTM! :) thanks for the contribution- and just for future notice, if you're making a change directly onto the codebase (i.e. not documentation/examples), it's required to add a changeset but i've gone ahead and put one in for you!

@jodeleeuw
Copy link
Member

@jadeddelta is this an issue in any of the other button plugins?

(might be worth adding a test case to verify that disabling is happening as expected)

@jadeddelta
Copy link
Collaborator

looks like it's not an issue in other plugins, and in fact this specific plugin does have a disabled button test, it was just skipping it because the array that querySelectorAll generated was always empty, meaning it would never reach the expect statements. went ahead and added a check for it, should all be good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants