Use DetailedTestDiagnostic from EISOP instead of DetailMessage
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just noticed that in eisop/checker-framework#758 I did break how this project parses the detailed diagnostics itself... I've filed eisop/checker-framework#809 and can look into fixing this. |
cpovirk
approved these changes
Jul 24, 2024
wmdietl
commented
Jul 25, 2024
| if (detailMessage.hasDetails()) { | ||
| // Replace diagnostics that can be parsed with DetailMessage diagnostics. | ||
| i.set(detailMessage); | ||
| if (diagnostic instanceof DetailedTestDiagnostic) { |
There was a problem hiding this comment.
As the normal tests are executed without -Adetailedmsgtext, this is likely a dead branch. I'll address this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes together with eisop/checker-framework#758.
Parsing the detailed test diagnostics is also needed for the EISOP JSpecify conformance tests, so we directly implemented a
DetailedTestDiagnosticclass in EISOP that can also be used here.Not strictly necessary to do, but would reduce the code in this repository and protect against changes in the error format.