Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected diagnostics that aren't in "detail message" format. #130

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Jan 8, 2024

Otherwise they were getting swallowed and never emitted even in details mode.

@netdpb netdpb requested review from wmdietl and cpovirk January 8, 2024 19:17
Copy link
Collaborator

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle unexpected diagnostics that aren't emitted by the framework as "detail messages".

I mis-parsed that at first: The diagnostics are emitted, but they're emitted in a format other than the detail-message format :) SGTM.

@netdpb netdpb changed the title Handle unexpected diagnostics that aren't emitted by the framework as "detail messages". Handle unexpected diagnostics that aren't in "detail message" format. Jan 8, 2024
@netdpb
Copy link
Collaborator Author

netdpb commented Jan 8, 2024

Thanks. I've updated the title to be less misparseable.

@netdpb netdpb requested a review from cpovirk January 8, 2024 22:13
@netdpb netdpb merged commit 6346be0 into jspecify:main Jan 8, 2024
2 checks passed
@netdpb netdpb deleted the unexpected-diagnostics branch January 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants