Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test #119

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Build and test #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed81412
Build and test in one step, since `build` already depends on `conform…
netdpb Dec 11, 2023
521e6b2
Merge branch 'main' of github.com:jspecify/nullness-checker-for-check…
netdpb Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,12 @@ jobs:
with:
distribution: temurin
java-version: 17
- name: Build
- name: Build and Test
uses: gradle/gradle-build-action@v2
with:
arguments: build
arguments: build conformanceTests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
arguments: build conformanceTests
arguments: conformanceTests

Given your point about the dependency that's declared, would it make sense to request just conformanceTests? If nothing else, it could be nice to know if that request stops working, especially if it's what we'd tell our (legions of) users to run.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, build depends on more than just conformanceTests, so your suggestion would not run all the verification tasks.

It used to be that the conformance tests, like the samples, were separate from the normal Gradle build lifecycle. But now they're not. conformanceTests is part of check, which is the lifecycle task for all verification, and which build depends on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks. For starters, I did have it backward: While your message had said that build depends on conformanceTests, I read it the other way around (presumably from being used to the Bazel terminology).

I guess that my question should have been whether we might want to pass only build?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that. But I thought this would make it a little more explicit. I checked, and this doesn't run conformanceTests twice.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

env:
SHALLOW: 1
- name: Run Conformance Tests
uses: gradle/gradle-build-action@v2
with:
arguments: conformanceTests
- name: Check out jspecify/samples-google-prototype
run: git -C ../jspecify checkout samples-google-prototype
- name: Run Samples Tests
Expand Down