Refactor AbstractConformanceTest into a runner rather than a base class
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and start depending on the conformance test artifact.
… and a regular jar containing compiled dependencies.
…it take a delegate rather than have subclasses. Change `checkConformance()` from a JUnit test to a method that takes the test directory, test deps, and test report file as arguments. Change `ConformanceTest` to be that delegate, and to have two JUnit test methods: one for the normal conformance tests and one for the conformance tests running on the samples directory. Change the build file to work with the new structure.
…er-framework into act-refactor
cpovirk
approved these changes
Dec 7, 2023
…d of the old `conformanceTest` and `conformanceTestOnSamples`.
cpovirk
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will decouple the conformance test framework from JUnit.
Fixes #111.