Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle build cleanup #110

Merged
merged 16 commits into from
Nov 17, 2023
Merged

Gradle build cleanup #110

merged 16 commits into from
Nov 17, 2023

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Nov 16, 2023 •
edited
Loading

  • Clean up dependency references, including to the conformance test framework.
  • Use a version catalog.
  • Set the conformance test framework version to "0-SNAPSHOT".
  • Clean up Gradle warnings.

@netdpb netdpb requested review from cpovirk and wmdietl November 16, 2023 20:25
cpovirk
cpovirk approved these changes Nov 17, 2023
View reviewed changes
conformance/build.gradle Outdated Show resolved Hide resolved
wmdietl
wmdietl approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

settings.gradle Show resolved Hide resolved
conformance/build.gradle Outdated Show resolved Hide resolved
@netdpb netdpb merged commit 4f27d72 into jspecify:main Nov 17, 2023
2 checks passed
@netdpb netdpb deleted the build-cleanup branch November 17, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

@cpovirk cpovirk cpovirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netdpb @cpovirk @wmdietl