Emit report lines for expected facts in the same order in which they …

…appear in the input file. (#105) Fixes #103.
jspecify · Aug 23, 2023 · c183d5b · c183d5b
1 parent 9e6590f
commit c183d5b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/src/test/java/tests/conformance/AbstractConformanceTest.java b/src/test/java/tests/conformance/AbstractConformanceTest.java
@@ -26,9 +26,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
 import java.util.ListIterator;
+import java.util.Map;
 import java.util.Objects;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -122,19 +123,20 @@ private Stream<ConformanceTestReport> analyzeFiles(List<Path> files) {
   private ImmutableList<ExpectedFact> readExpectedFacts(Path file) {
     try {
       ImmutableList.Builder<ExpectedFact> expectedFacts = ImmutableList.builder();
-      List<String> facts = new ArrayList<>();
+      Map<Long, String> facts = new HashMap<>();
       for (ListIterator<String> i = readAllLines(testDirectory.resolve(file), UTF_8).listIterator();
           i.hasNext(); ) {
         String line = i.next();
+        long lineNumber = i.nextIndex();
         Matcher matcher = EXPECTATION_COMMENT.matcher(line);
         String fact = matcher.matches() ? readExpectedFact(matcher.group("expectation")) : null;
         if (fact != null) {
-          facts.add(fact);
+          facts.put(lineNumber, fact);
         } else {
-          long lineNumber = i.nextIndex();
-          facts.stream()
-              .map(expectedFact -> new ExpectedFact(file, lineNumber, expectedFact))
-              .forEach(expectedFacts::add);
+          facts.forEach(
+              (factLineNumber, expectedFact) ->
+                  expectedFacts.add(
+                      new ExpectedFact(file, lineNumber, expectedFact, factLineNumber)));
           facts.clear();
         }
       }
@@ -302,17 +304,24 @@ public static boolean isNullnessMismatch(String fact) {
     }
 
     private final String fact;
+    private final long factLineNumber;
 
-    ExpectedFact(Path file, long lineNumber, String fact) {
+    ExpectedFact(Path file, long lineNumber, String fact, long factLineNumber) {
       super(file, lineNumber);
       this.fact = fact;
+      this.factLineNumber = factLineNumber;
     }
 
     @Override
     public String getFactText() {
       return fact;
     }
 
+    /** Returns the line number in the input file where the expected fact is. */
+    public long getFactLineNumber() {
+      return factLineNumber;
+    }
+
     @Override
     public boolean equals(Object o) {
       if (this == o) {

diff --git a/src/test/java/tests/conformance/ConformanceTestReport.java b/src/test/java/tests/conformance/ConformanceTestReport.java
@@ -49,7 +49,6 @@ static ConformanceTestReport forFile(
         index(reportedFacts, ReportedFact::getLineNumber);
     ImmutableListMultimap<ExpectedFact, ReportedFact> matchingFacts =
         expectedFacts.stream()
-            .sorted(comparingLong(ExpectedFact::getLineNumber))
             .collect(
                 flatteningToImmutableListMultimap(
                     f -> f,
@@ -112,9 +111,12 @@ public String report(boolean details) {
           ImmutableSortedSet.copyOf(
               union(expectedFactsInFile.keySet(), reportedFactsInFile.keySet()))) {
         // Report all expected facts on this line and whether they're reported or not.
-        for (ExpectedFact expectedFact : expectedFactsInFile.get(lineNumber)) {
-          writeFact(report, expectedFact, matchesReportedFact(expectedFact) ? "PASS" : "FAIL");
-        }
+        expectedFactsInFile.get(lineNumber).stream()
+            .sorted(comparingLong(ExpectedFact::getFactLineNumber))
+            .forEach(
+                expectedFact ->
+                    writeFact(
+                        report, expectedFact, matchesReportedFact(expectedFact) ? "PASS" : "FAIL"));
         if (details) {
           // Report all unexpected facts on this line and whether they must be expected or not.
           for (ReportedFact reportedFact : reportedFactsInFile.get(lineNumber)) {