Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: David P. Baker <[email protected]>
  • Loading branch information
wmdietl and netdpb authored Dec 14, 2023
1 parent ac78d1c commit 02160b6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions initialize-project
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,12 @@ git_clone() {
return
fi
fi
if [[ "${repo}" == "checker-framework" ]]; then
run "${git[@]}" "https://github.com/eisop/checker-framework.git" "../checker-framework"
if [[ "${repo}" == checker-framework ]]; then
forking_org=https://github.com/eisop
else
run "${git[@]}" "https://github.com/jspecify/${repo}.git" "../${repo}"
forking_org=https://github.com/jspecify
fi
run "${git[@]}" "${forking_org}/${repo}.git" "../${repo}"
}

# Fetch all branches even when $SHALLOW is set so we can check out
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ protected String extraArgForReturnTypeError(Tree tree) {
* the possibly null value (possibly both!). However, this gets tricky: If the branches return
* `Foo?` and `Foo*`, then we ideally want to emphasize the `Foo?` branch *but*, at least in
* "strict mode," not altogether ignore the `Foo*` branch.
*
/
String origin = originStringIfTernary(tree);
return origin.isEmpty() ? "" : (origin + "\n");
}
Expand Down

0 comments on commit 02160b6

Please sign in to comment.