-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#62 Switch to platform options from deprecated custom schema options #64
Conversation
Hi @sasa-b I'm seeing the same issue trying to upgrade to doctrine/orm 2.16.2. We get the error you mention in #62 while running I installed this branch locally like so: Edit composer.json: {
"repositories": [
{
"type": "git",
"url": "https://github.com/sasa-b/doctrine-postgis"
}
],
"require": {
"jsor/doctrine-postgis": "dev-migration-diff-fix"
}
} Then run I can confirm the error goes away and locally everything looks fine. I looked at the code and I can only say "LGTM". What can we do to move this forward? @jsor Would you be available for review? |
It seems the issue appears starting doctrine/orm 2.15.5 In this version, doctrine/orm started using platformOptions instead of customSchemaOptions https://github.com/doctrine/orm/releases/tag/2.15.5 We're pinning to < 2.15.5 for now, waiting for this PR to land |
I have the same issue here. Is any help needed to get this merged? |
@jsor would really appreciate if we could push this forward. It's somewhat of a blocker preventing us to move forward with new doctrine/orm versions. Many thanks for your time. |
It would be great to merge this PR. We also are stuck with doctrine/orm versions. Thanks a lot in advance! |
Isn't this related (or maybe fixed too) on #61 ? |
Thank you for merging @jsor 🙏 |
@jsor many thanks for merging! ... Could we have a new tag? |
@jsor thanks for merging! 🙌 |
As suspected the issue in #62 was due to using the deprecated
customSchemaOptions
property.Btw this package works with PostgreSQL 15 as well, I've just noticed I've been using it with that version all this time without any issues so far, although the highest officially supported version was 13.