generated from json-schema-org/repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform DSL documentation #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suprith-hub
commented
Jun 11, 2024
•
edited
Loading
edited
- Does it require more information on sibling property each transform operation takes?
- For the 2nd operation prefix-until-unique and for copy, add. Can I have complicated examples like that
- Should I arrange in alphabetical order
jviotti
reviewed
Jun 12, 2024
jviotti
reviewed
Jun 12, 2024
jviotti
reviewed
Jun 12, 2024
jviotti
reviewed
Jun 12, 2024
jviotti
reviewed
Jun 12, 2024
The reason why I didn't choose "path" is because it causes ambiguity betwe
from and to. So., "path" is used only where we deal with "value"
…On Fri, 14 Jun 2024 at 4:16 AM, Juan Cruz Viotti ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DSL/transform.md
<#9 (comment)>
:
> +
+| Property | Description | Required | Data Type |
+|-----------|------------------------------------------------------------------|----------|-------------------|
+| operation | Specifies the operation to perform | Yes | String |
+| path | Specifies the path to the target in the schema | Yes | Array of Strings |
+| value | Specifies the value to be used in the operation | No | Any |
+| from | Specifies the source path for operations involving move/copy | No | Array of Strings |
+| to | Specifies the destination path for operations involving move/copy| No | Array of Strings |
+
+## Operations
+
+### 1. `append-property`
+
+Appends property in the provided `from` path to the `to` path. The `to` path should be an array, or it will be created as an empty array before appending.
+
+- **Takes**: `from`, `to`
Hmm I think we can at least rename from to path (because it's actually a
path?)
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASS4PJ2BKPNALVFAOSIBMFTZHIOM5AVCNFSM6AAAAABJFAKVI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGE2DGNBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
@jviotti I have made the changes |
jviotti
reviewed
Jun 17, 2024
jviotti
reviewed
Jun 17, 2024
jviotti
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about some stylistic issues I found, but looks good otherwise. As we work on the implementation of the rules, please make sure you keep this file up to date!
Co-authored-by: Juan Cruz Viotti <[email protected]>
Co-authored-by: Juan Cruz Viotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.