Add ref adjacent keywords case for Draft3 to Draft4 transform #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
reviewed
Aug 16, 2024
test/from-draft3/to-draft4/ref.json
Outdated
| { | ||
| "title": "$ref present in schema, with adjacent keywords", | ||
| "from": { | ||
| "$id": "http://example.com", |
There was a problem hiding this comment.
In Draft 3 and Draft 4, there is no $id, but id
suprith-hub
changed the title
suprith-hub
changed the title
jviotti
approved these changes
Aug 28, 2024
|
Looks good but there are conflicts? |
@jviotti I am closing and reopening the PR for this... case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.