Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform exclusiveMaximum and exclusiveMinimum from Draft 4 to Draft 6 #41

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

suprith-hub
Copy link
Collaborator

No description provided.

@jviotti
Copy link
Member

jviotti commented Aug 5, 2024

As a minor comment, you should be more careful about PR titles. "Draft4 to6exclusive" is poorly written, missing spaces, consistent naming, etc. PR titles will remain forever, so you should make sure to write them well. For example, a better PR title would have been "Transform exclusiveMaximum and exclusiveMinimum from Draft 4 to Draft 6"

@jviotti jviotti changed the title Draft4 to6exclusive Transform exclusiveMaximum and exclusiveMinimum from Draft 4 to Draft 6 Aug 5, 2024
@jviotti jviotti merged commit a226338 into main Aug 5, 2024
1 check passed
@jviotti jviotti deleted the draft4To6exclusive branch August 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants